linux-kernel - Re: [PATCH] Add Ultrabay support for the T60p Thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061231162951.GA13022@khazad-dum.debian.net>
Date:	Sun, 31 Dec 2006 14:29:51 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org,
	ibm-acpi-devel@...ts.sourceforge.net, Whoopie <whoopie79@....net>
Subject: Re: [PATCH] Add Ultrabay support for the T60p Thinkpad

Whoopie from ThinkWiki just sent me an email, calling my attention to the
fact that the patch you submitted is in fact different from the one I
merged... something I should have triple-verified.  It appears the t60p has
the bay in a different ACPI node than some other *60 ThinkPads.  Either
that, or the node moves depending on ICHR mode set in the BIOS.

So I apologise for the screw up, and:

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

I am merging your patch into the ibm-acpi tree and will ask Len to push it
to Linus.  Now, please excuse me while I go look for a new brown-paperbag
hat...

On Sun, 10 Dec 2006, Theodore Ts'o wrote:
> Add Ultrabay Support for the T60p Thinkpad
> 
> The following patch adds support for obtaining the status and ejecting
> Ultrabay devices for the T60p Thinkpad; my guess is that it probably
> works on T60 Thinkpads and probably more recent Lenovo latops as well.
> 
> With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay
> carrier by using the command:
> 
>   "echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"
> 
> and upon re-inserting the it back into the device and issuing the
> command:
> 
>  "echo 0 0 0 > /sys/class/scsi_host/host1/scan"
> 
> have the device appear again.  (With the 1.02 BIOS the device does not
> function when re-inserted, even after a warm boot; a cold reboot is
> required to store the Ultrabay device's functionality.)
> 
> More complicated Ultrabay eject and insert scripts can be found on the
> ThinkWiki, although it's important to comment out the "hdparm -Y" as it
> apparently doesn't work or do anything, and causes the eject process to
> hang for about a minute.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> 
> Index: 2.6.19/drivers/acpi/ibm_acpi.c
> ===================================================================
> --- 2.6.19.orig/drivers/acpi/ibm_acpi.c	2006-12-09 18:35:09.000000000 -0500
> +++ 2.6.19/drivers/acpi/ibm_acpi.c	2006-12-09 18:35:42.000000000 -0500
> @@ -169,6 +169,7 @@
>  #endif
>  IBM_HANDLE(bay, root, "\\_SB.PCI.IDE.SECN.MAST",	/* 570 */
>  	   "\\_SB.PCI0.IDE0.IDES.IDSM",	/* 600e/x, 770e, 770x */
> +	   "\\_SB.PCI0.IDE0.PRIM.MSTR",	/* T60p */
>  	   "\\_SB.PCI0.IDE0.SCND.MSTR",	/* all others */
>      );				/* A21e, R30, R31 */
>  

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/