linux-kernel - 2.6.20 regression: suspend to disk no more works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jan 2007 22:44:42 +0300
From:	Andrey Borzenkov <arvidjaar@...l.ru>
To:	linux-kernel@...r.kernel.org
Cc:	linux-pm@...l.org
Subject: 2.6.20 regression: suspend to disk no more works

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In *the same* configuration STD now fails with "Cannot find swap device". The 
reason is changes in kernel/power/swap.c. In 2.6.19 it did not require valid 
swsusp_resume_device at all - it took first available swap device and saved 
image. Later during resume swsusp_resume_device was set either by command 
line or sysfs and everything worked nicely.

Now swsusp_swap_check() unfortunately checks for swsusp_resume_device at 
*suspend* time:

        res = swap_type_of(swsusp_resume_device, swsusp_resume_block);
        if (res < 0)
                return res;

        root_swap = res;
        resume_bdev = open_by_devnum(swsusp_resume_device, FMODE_WRITE);
        if (IS_ERR(resume_bdev))
                return PTR_ERR(resume_bdev);

but in case of modular driver for swap device this is likely to be undefined. 
This is as of 2.6.20-rc3.

I already have seen these reports. While 'echo a:b > /sys/power/resume' before 
suspend is a workaround, this still breaks perfectly valid setup that worked 
before. Also 'echo a:b > /sys/power/resume' is actually wrong - we are not 
going to resume at this point; but there is no way to just tell kernel "use 
this device for next STD" ... also the error message is misleading, it should 
complaint "no resume device found". Swap is there all right.

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFmWSqR6LMutpd94wRAu61AJ9mdbF4W6RNQ848PU0e4n/3MKtNnwCgzwOh
HkZ9e8lHPMH1tRNzCw/2O58=
=HlW4
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/