linux-kernel - [PATCH] video: cpia module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200701021325.29317.m.kozlowski@tuxland.pl>
Date:	Tue, 2 Jan 2007 13:25:28 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	mchehab@...radead.org
Cc:	video4linux-list@...hat.com, linux-kernel@...r.kernel.org
Subject: [PATCH] video: cpia module_put cleanup

Hello,

	No need for redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 drivers/media/video/cpia.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/drivers/media/video/cpia.c linux-2.6.20-rc2-mm1-b/drivers/media/video/cpia.c
--- linux-2.6.20-rc2-mm1-a/drivers/media/video/cpia.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/drivers/media/video/cpia.c	2007-01-02 02:28:01.000000000 +0100
@@ -3153,8 +3153,7 @@ static int reset_camera(struct cam_data 
 
 static void put_cam(struct cpia_camera_ops* ops)
 {
-	if (ops->owner)
-		module_put(ops->owner);
+	module_put(ops->owner);
 }
 
 /* ------------------------- V4L interface --------------------- */


-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/