linux-kernel - [PATCH] lib: kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200701021344.44258.m.kozlowski@tuxland.pl>
Date:	Tue, 2 Jan 2007 13:44:44 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] lib: kobject_put cleanup

Hello,

	This patch removes redundant argument checks for kobject_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 lib/kobject.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/lib/kobject.c linux-2.6.20-rc2-mm1-b/lib/kobject.c
--- linux-2.6.20-rc2-mm1-a/lib/kobject.c	2006-12-28 12:57:53.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/lib/kobject.c	2007-01-02 02:31:54.000000000 +0100
@@ -237,8 +237,7 @@ int kobject_add(struct kobject * kobj)
 	if (error) {
 		/* unlink does the kobject_put() for us */
 		unlink(kobj);
-		if (parent)
-			kobject_put(parent);
+		kobject_put(parent);
 
 		/* be noisy on error issues */
 		if (error == -EEXIST)
@@ -464,8 +463,7 @@ void kobject_cleanup(struct kobject * ko
 
 	if (s)
 		kset_put(s);
-	if (parent) 
-		kobject_put(parent);
+	kobject_put(parent);
 }
 
 static void kobject_release(struct kref *kref)


-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/