linux-kernel - Re: [PATCH] sound: aoa of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1167743529.13592.44.camel@johannes.berg>
Date:	Tue, 02 Jan 2007 14:12:08 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] sound: aoa of_node_put and kfree cleanup

On Tue, 2007-01-02 at 13:50 +0100, Mariusz Kozlowski wrote:

> 	This patch removes redundant argument checks for of_node_put() and kfree().

Looks good to me, thanks.

> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

Acked-by: Johannes Berg <johannes@...solutions.net>

>  sound/aoa/fabrics/snd-aoa-fabric-layout.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -upr linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c
> --- linux-2.6.20-rc2-mm1-a/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2006-12-28 12:57:54.000000000 +0100
> +++ linux-2.6.20-rc2-mm1-b/sound/aoa/fabrics/snd-aoa-fabric-layout.c	2007-01-02 01:50:26.000000000 +0100
> @@ -1034,9 +1034,9 @@ static int aoa_fabric_layout_probe(struc
>  	list_del(&ldev->list);
>  	layouts_list_items--;
>   outnodev:
> - 	if (sound) of_node_put(sound);
> + 	of_node_put(sound);
>   	layout_device = NULL;
> - 	if (ldev) kfree(ldev);
> + 	kfree(ldev);
>  	return -ENODEV;
>  }
>  
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)