linux-kernel - Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <459ACF51.1010501@garzik.org>
Date:	Tue, 02 Jan 2007 16:32:01 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan <alan@...rguk.ukuu.org.uk>, Linus Torvalds <torvalds@...l.org>
CC:	Alessandro Suardi <alessandro.suardi@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and
 v2.6.20-rc3 released))

Jeff Garzik wrote:
> * After your patch, the code explicitly calls pci_request_region() for 
> BARs 0-4, but never for BAR5.

Without checking for failures, I might add.

Let's call that regression/obvious bug #4, because the previous code 
actually CARED if the resource was reserved.

>                 if (legacy_mode & ATA_PORT_PRIMARY)
>                         pci_request_region(pdev, 1, DRV_NAME);
>                 if (legacy_mode & ATA_PORT_SECONDARY)
>                         pci_request_region(pdev, 3, DRV_NAME);
>                 /* If there is a DMA resource, allocate it */
>                 pci_request_region(pdev, 4, DRV_NAME);

I agree this is one way to avoid conflicts!  ;-)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/