linux-kernel - Re: [PATCH] net: ifb error path loop fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070102.152037.39159030.davem@davemloft.net>
Date:	Tue, 02 Jan 2007 15:20:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	m.kozlowski@...land.pl
Cc:	hadi@...erus.ca, netdev@...r.kernel.org, jeff@...zik.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ifb error path loop fix

From: Mariusz Kozlowski <m.kozlowski@...land.pl>
Date: Tue, 2 Jan 2007 11:49:42 +0100

> Hello David, 
> 
> > One could argue from a defensive programming perspective that
> > this bug comes from the fact that the ifb_init_one() loop
> > advances state before checking for errors ('i' is advanced before
> > the 'err' check due to the loop construct), and that's why the
> > error recovery code had to be coded specially :-)
> 
> Now when I look at it I might be wrong and it is not a bug at all. 
> It's just coded in weird way. Anyway isn't there kfree(ifbs) missing
> on error path?
> 
> The patch below should clear things a bit (against plain 2.6.20-rc2-mm1).
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

Ok, I've removed the original patch from my tree.

I'll let this cleanup sit for a while so others can review
it :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/