linux-kernel - Re: [PATCH] Sun3 SCSI: Make sun3 scsi drivers compile/work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070102113143.GB24951@infradead.org>
Date:	Tue, 2 Jan 2007 11:31:44 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linus Torvalds <torvalds@...l.org>, Andrew Morton <akpm@...l.org>,
	linux-scsi@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Sam Creasey <sammy@...my.net>
Subject: Re: [PATCH] Sun3 SCSI: Make sun3 scsi drivers compile/work again

On Sat, Dec 09, 2006 at 10:37:05AM +0100, Geert Uytterhoeven wrote:
> +#include "initio.h"

This is definitly wrong.  This is a header file for a specific driver.
I suspect you want the old-EH definitions for SCSI_RESET_*/SCSI_ABORT_*?

You're returning them from the EH routines which are plugged into the
new EH method slots, so this is not only wrong by including an other
drivers private headers but also functionally deadly.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/