linux-kernel - Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <459B00AB.3090004@pobox.com>
Date:	Tue, 02 Jan 2007 20:02:35 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan <alan@...rguk.ukuu.org.uk>
CC:	Linus Torvalds <torvalds@...l.org>,
	Alessandro Suardi <alessandro.suardi@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and
 v2.6.20-rc3 released))

Alan wrote:
> Once combined mode is fixed not to abuse resources (and it originally
> did it that way for a good reason I grant and am not criticising that) the
> entire management for legacy mode, mixed mode and native mode resources
> for an ATA device (including 0x170, 0x3F6 and other wacky magic) becomes
> 
> 	if (pci_request_regions(pdev, "libata")) ...

> Make sense ?

Yes.  For 2.6.21.  As I've always said.

But for 2.6.20, we are only HALFWAY there, and all these /new/ bugs 
exist as a result.

Your patch makes far more sense for 2.6.21, where the "halfway to 
salvation" state, and associated rough edges, is not exposed to users.

Fixing the resource tree was only half the solution, since the drivers 
that /use/ the resource tree now need updating.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/