linux-kernel - [PATCH] gitweb: Make shortlog use 'h' (head) parameter again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <11678562042320-git-send-email-jnareb@gmail.com>
Date:	Wed,  3 Jan 2007 21:30:04 +0100
From:	Jakub Narebski <jnareb@...il.com>
To:	git@...r.kernel.org
Cc:	Michael Krufky <mkrufky@...uxtv.org>, linux-kernel@...r.kernel.org,
	Jakub Narebski <jnareb@...il.com>
Subject: [PATCH] gitweb: Make shortlog use 'h' (head) parameter again

This fixes typo in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6

Signed-off-by: Jakub Narebski <jnareb@...il.com>
---
Michael Krufky wrote:

> Ever since gitweb on kernel.org was recently updated, I've been experiencing a
> nasty bug -- It seems that it is no longer possible to view a shortlog from any
> branch or head other than master.
[...]
> "log" and "tree" is working properly -- it seems that "shortlog" is the only
> feature affected by this bug.

This corrects this bug.  When introducing parse_commits to shortlog,
there was typo in parse_commits arguments: it was $head instead of $hash.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 2ead917..2179054 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4423,7 +4423,7 @@ sub git_shortlog {
 	}
 	my $refs = git_get_references();
 
-	my @commitlist = parse_commits($head, 101, (100 * $page));
+	my @commitlist = parse_commits($hash, 101, (100 * $page));
 
 	my $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));
 	my $next_link = '';
-- 
1.4.4.3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/