linux-kernel - Re: [UPDATED PATCH] fix memory corruption from misinterpreted bad_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0701041325510.3661@woody.osdl.org>
Date:	Thu, 4 Jan 2007 13:30:47 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Eric Sandeen <sandeen@...hat.com>
cc:	Andrew Morton <akpm@...l.org>, Al Viro <viro@....linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [UPDATED PATCH] fix memory corruption from misinterpreted
 bad_inode_ops return values

On Thu, 4 Jan 2007, Eric Sandeen wrote:
> Andrew Morton wrote:
> 
> > btw, couldn't we fix this bug with a simple old
> > 
> > --- a/fs/bad_inode.c~a
> > +++ a/fs/bad_inode.c
> > @@ -15,7 +15,7 @@
> >  #include <linux/smp_lock.h>
> >  #include <linux/namei.h>
> >  
> > -static int return_EIO(void)
> > +static long return_EIO(void)
> >  {
> >  	return -EIO;
> >  }
> > _
> > 
> > ?
> 
> What about ops that return loff_t (64 bits) on 32-bit arches and stuff
> it into 2 registers....

Do we actually have cases where we cast to a different return value?

I'll happily cast away arguments that aren't used, but I'm not sure that 
we ever should cast different return values (not "int" vs "long", but also 
not "loff_t" etc). 

On 32-bit architectures, 64-bit entities may be returned totally different 
ways (ie things like "caller allocates space for them and passes in a 
magic pointer to the return value as the first _real_ argument").

So with my previous email, I was definitely _not_ trying to say that 
casting function pointers is ok. In practice it is ok when the _arguments_ 
differ, but not necessarily when the _return-type_ differs.

I was cc'd into the discussion late, so I didn't realize that we 
apparently already have a situation where changing the return value to 
"long" might make a difference. If so, I agree that we shouldn't do this 
at all (although Andrew's change to "long" seems perfectly fine as a "make 
old cases continue to work" patch if it actually matters).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/