From: Sébastien Dugué Move good_sigevent() from posix-timers.c to signal.c where it belongs, and make it non-static so that it can be used by other subsystems. Signed-off-by: Sébastien Dugué Signed-off-by: Bharata B Rao --- include/linux/signal.h | 1 + kernel/posix-timers.c | 17 ----------------- kernel/signal.c | 24 ++++++++++++++++++++++++ 3 files changed, 25 insertions(+), 17 deletions(-) diff -puN include/linux/signal.h~export-good_sigevent include/linux/signal.h --- linux-2.6.20-rc2/include/linux/signal.h~export-good_sigevent 2007-01-03 10:17:28.000000000 +0530 +++ linux-2.6.20-rc2-bharata/include/linux/signal.h 2007-01-03 10:17:28.000000000 +0530 @@ -240,6 +240,7 @@ extern int sigprocmask(int, sigset_t *, struct pt_regs; extern int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka, struct pt_regs *regs, void *cookie); +extern struct task_struct * good_sigevent(sigevent_t *); extern struct kmem_cache *sighand_cachep; diff -puN kernel/posix-timers.c~export-good_sigevent kernel/posix-timers.c --- linux-2.6.20-rc2/kernel/posix-timers.c~export-good_sigevent 2007-01-03 10:17:28.000000000 +0530 +++ linux-2.6.20-rc2-bharata/kernel/posix-timers.c 2007-01-03 10:17:28.000000000 +0530 @@ -367,23 +367,6 @@ static enum hrtimer_restart posix_timer_ return ret; } -static struct task_struct * good_sigevent(sigevent_t * event) -{ - struct task_struct *rtn = current->group_leader; - - if ((event->sigev_notify & SIGEV_THREAD_ID ) && - (!(rtn = find_task_by_pid(event->sigev_notify_thread_id)) || - rtn->tgid != current->tgid || - (event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_SIGNAL)) - return NULL; - - if (((event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_NONE) && - ((event->sigev_signo <= 0) || (event->sigev_signo > SIGRTMAX))) - return NULL; - - return rtn; -} - void register_posix_clock(const clockid_t clock_id, struct k_clock *new_clock) { if ((unsigned) clock_id >= MAX_CLOCKS) { diff -puN kernel/signal.c~export-good_sigevent kernel/signal.c --- linux-2.6.20-rc2/kernel/signal.c~export-good_sigevent 2007-01-03 10:17:28.000000000 +0530 +++ linux-2.6.20-rc2-bharata/kernel/signal.c 2007-01-04 13:21:28.000000000 +0530 @@ -1213,6 +1213,30 @@ int group_send_sig_info(int sig, struct return ret; } +/*** + * good_sigevent - check and get target task from a sigevent. + * @event: the sigevent to be checked + * + * This function must be called with the tasklist_lock held for reading. + */ +struct task_struct * good_sigevent(sigevent_t * event) +{ + struct task_struct *task = current->group_leader; + + if ((event->sigev_notify & SIGEV_THREAD_ID ) == SIGEV_THREAD_ID) { + task = find_task_by_pid(event->sigev_notify_thread_id); + + if (!task || task->tgid != current->tgid) + return NULL; + } else if (event->sigev_notify == SIGEV_SIGNAL) { + if ((event->sigev_signo <= 0) || (event->sigev_signo > SIGRTMAX)) + return NULL; + } else + return NULL; + + return task; +} + /* * kill_pgrp_info() sends a signal to a process group: this is what the tty * control characters do (^C, ^Z etc) _