linux-kernel - Re: [PATCH] slab: fix double-free in fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0701052037100.4444@blonde.wat.veritas.com>
Date:	Fri, 5 Jan 2007 20:46:42 +0000 (GMT)
From:	Hugh Dickins <hugh@...itas.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	clameter@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slab: fix double-free in fallback_alloc

On Fri, 5 Jan 2007, Pekka J Enberg wrote:
> 
> Here's an alternative fix for the double-free bug you hit. I have only 
> compile-tested this on NUMA so can you please confirm it fixes the problem 
> for you? Thanks.

It looks nice, and I'm giving it a spin: though hardly worth waiting
a week or so to see if it hits the old double-free (took 3.5 days of
load when I saw it before), since you've fairly clearly rearranged
that out of existence - any bugs will be new ones all your own ;)

And I don't really have any NUMA anyway, just build that way ever
since testing some mempolicy change.  So don't pay much attention to
my results, though of course I'll let you know if I see it go wrong.

The main thing is to make sure that your patch doesn't end up applied
to a tree with my patch in, since that would then be a (rare) leak.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/