linux-kernel - Re: [PATCH] cx88xx: Fix lockup on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Jan 2007 17:32:05 +0000
From:	Pavel Machek <pavel@....cz>
To:	Robert Hancock <hancockr@...w.ca>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, mchehab@...radead.org,
	v4l-dvb-maintainer@...uxtv.org
Subject: Re: [PATCH] cx88xx: Fix lockup on suspend

Hi!

> Suspending with the cx88xx module loaded causes the 
> system to lock up because the cx88_audio_thread kthread 
> was missing a try_to_freeze() call, which caused it to 
> go into a tight loop and result in softlockup when 
> suspending. Fix that.
> 
> Signed-off-by: Robert Hancock <hancockr@...w.ca>
>

Ack,
 
> --- 
> linux-2.6.20-rc3-git4-orig/drivers/media/video/cx88/cx88-tvaudio.c	2007-01-04 19:51:45.000000000 -0600
> +++ 
> linux-2.6.20-rc3-git4/drivers/media/video/cx88/cx88-tvaudio.c	2007-01-04 19:25:19.000000000 -0600
> @@ -38,6 +38,7 @@
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/errno.h>
> +#include <linux/freezer.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/mm.h>

but your patch was whitespace-damaged. Can you retry?

> @@ -961,6 +962,7 @@ int cx88_audio_thread(void *data)
> 		msleep_interruptible(1000);
> 		if (kthread_should_stop())
> 			break;
> +		try_to_freeze();
> 

							Pavel

-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/