linux-kernel - Re: [PATCH] qconf: fix SIGSEGV on empty menu items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <459F8C25.3090102@xs4all.nl>
Date:	Sat, 06 Jan 2007 12:46:45 +0100
From:	Bauke Jan Douma <bjdouma@...all.nl>
To:	Roman Zippel <zippel@...ux-m68k.org>
CC:	"Cyrill V. Gorcunov" <gorcunov@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] qconf: fix SIGSEGV on empty menu items

Roman Zippel wrote on 06-01-07 04:20:

<snip>

> Thanks, but this is more complex than necessary.
> It simply lacks some initializers.

<snip>

> ---
> Index: linux-2.6/scripts/kconfig/qconf.cc
> ===================================================================
> --- linux-2.6.orig/scripts/kconfig/qconf.cc	2007-01-05 01:47:54.000000000 +0100
> +++ linux-2.6/scripts/kconfig/qconf.cc	2007-01-05 01:56:54.000000000 +0100
> @@ -915,7 +915,7 @@ void ConfigView::updateListAll(void)
>  }
>  
>  ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
> -	: Parent(parent, name), menu(0)
> +	: Parent(parent, name), menu(0), sym(0)
>  {
>  	if (name) {
>  		configSettings->beginGroup(name);
> @@ -951,6 +951,7 @@ void ConfigInfoView::setInfo(struct menu
>  	if (menu == m)
>  		return;
>  	menu = m;
> +	sym = NULL;
>  	if (!menu)
>  		clear();
>  	else
> -

I can confirm that this patch squashed the segfault.

bjd


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/