linux-kernel - [PATCH] sysrq: showBlockedTasks is sysrq-W

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 6 Jan 2007 10:25:31 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Olaf Hering <olaf@...fle.de>
Cc:	lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org>,
	kernel@...dioc.dyndns.org
Subject: [PATCH] sysrq: showBlockedTasks is sysrq-W

On Fri, 5 Jan 2007 20:36:05 +0100 Olaf Hering wrote:

> On Fri, Jan 05, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > SysRq showBlockedTasks is not done via B or T, it's done via X,
> > so put that in the Help message.
> 
> Weird, who failed to run this command before adding new stuff?!
> find * -type f -print0 | xargs -0 env -i grep -nw register_sysrq_key
> 
> sysrq x is for xmon, see arch/powerpc/xmon/xmon.c
> Better switch the new stuff to 'z' or 'w'
---

From: Randy Dunlap <randy.dunlap@...cle.com>

SysRq showBlockedTasks is not done via B or T, it's done via W,
so put that in the Help message.

It was previously done via X, but X is already used for Xmon
on powerpc platforms and this collision needs to be avoided.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/char/sysrq.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2620-rc3g4.orig/drivers/char/sysrq.c
+++ linux-2620-rc3g4/drivers/char/sysrq.c
@@ -215,7 +215,7 @@ static void sysrq_handle_showstate_block
 }
 static struct sysrq_key_op sysrq_showstate_blocked_op = {
 	.handler	= sysrq_handle_showstate_blocked,
-	.help_msg	= "showBlockedTasks",
+	.help_msg	= "showBlockedTasks(W)",
 	.action_msg	= "Show Blocked State",
 	.enable_mask	= SYSRQ_ENABLE_DUMP,
 };
@@ -342,8 +342,8 @@ static struct sysrq_key_op *sysrq_key_ta
 	&sysrq_mountro_op,		/* u */
 	/* May be assigned at init time by SMP VOYAGER */
 	NULL,				/* v */
-	NULL,				/* w */
-	&sysrq_showstate_blocked_op,	/* x */
+	&sysrq_showstate_blocked_op,	/* w */
+	NULL,				/* x */
 	NULL,				/* y */
 	NULL				/* z */
 };
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/