linux-kernel - Re: [PATCH 1/3] atiixp.c: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58cb370e0701061812s49c4b1f5p5c5e99e5eea3bb89@mail.gmail.com>
Date:	Sun, 7 Jan 2007 03:12:59 +0100
From:	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>
To:	"Conke Hu" <conke.hu@...il.com>
Cc:	"Linux kernel mailing list" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...l.org>, "Greg KH" <greg@...ah.com>
Subject: Re: [PATCH 1/3] atiixp.c: remove unused code

On 1/6/07, Conke Hu <conke.hu@...il.com> wrote:
> A previous patch to atiixp.c was removed but some code has not been

This one?

http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab17443a3df35abe4b7529e83511a591aa7384f3

Doesn't it break existing setups without giving ANY warning?

theoretical (I don't have hardware in question) scenario:
- user uses atiixp and has modular libata/ahci (or no libata/ahci et all)
- user does kernel upgrade
- boot fails
- ...

If this is true please add something like

printk(KERN_WARNING "PCI: setting SB600 SATA to AHCI mode"
" (please use ahci driver instead of atiixp)\n");

to quirk_sb600_sata() so people will at least know what is wrong...

> cleaned. Now we remove these code sine they are no use any longer.

Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

[ but the patch is line wrapped and unfortunately doesn't apply ]

PS: please always cc: linux-ide@...r.kernel.org on PATA/SATA patches

Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/