linux-kernel - Re: [PATCH] math-emu/setcc: avoid gcc extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Jan 2007 14:22:28 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Segher Boessenkool <segher@...nel.crashing.org>,
	akpm <akpm@...l.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] math-emu/setcc: avoid gcc extension

On Sun, 7 Jan 2007, Randy Dunlap wrote:

> On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
>
> > There's an extra tab in that last line.  Could you also
> > please fix the indenting (use a tab, not spaces) -- I know
> > it was there originally, but since there are only a few
> > lines in that file like that...  :-)
>
> how's this one?
> ---
> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> setcc() in math-emu is written as a gcc extension statement
> expression macro that returns a value.  However, it's not used that
> way and it's not needed like that, so just make it a do-while
> non-extension macro so that we don't use an extension when it's not
> needed.

is that the proposed coding style for macros?  if it returns a value,
use "({ })"?  if not, use the "do ... while" notation?

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/