linux-kernel - Re: [PATCH] sata_via: PATA support, resubmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45A2688E.3080503@pobox.com>
Date:	Mon, 08 Jan 2007 10:51:42 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan <alan@...rguk.ukuu.org.uk>
CC:	akpm@...l.org, torvalds@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sata_via: PATA support, resubmit

Alan wrote:
>> The problem you need to fix or work around is ata_probe_ent, which 
>> doesn't properly fill in ata_port info for this situation.  Tejun has 
>> posted patches that kill ata_probe_ent, which you were pointed to. 
> 
> And which are not yet in the main tree leaving many users unable to
> install Linux.

The controllers affected by your patch have been around for well over a 
year.  I doubt a huge amount of suffering will be caused by pausing to 
get it right...  especially when you have been pointed at two working 
code examples that already get it right.

> This isn't the way to get stuff done. When you've got the
> new patches in the driver can use them if its worth it (which, see below,
> I question).

In Linux, we work /with/ the subsystem, not around it.

Your current approach is fundamentally flawed.  You can see this because 
e.g. a call to vt6421_ops::scr_read() will immediately oops, after your 
patch.

Just separate PATA and SATA operations.  That way everything works as 
expected, and you don't unintentionally add lovely oopses all over the 
place.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/