linux-kernel - Re: [PATCH] Add pci class code for SATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 07 Jan 2007 21:29:33 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Conke Hu <conke.hu@...il.com>
CC:	Alan <alan@...rguk.ukuu.org.uk>, Andrew Morton <akpm@...l.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add pci class code for SATA

Conke Hu wrote:
> or, pls see this one:
> ------------------------
> diff -Nur linux-2.6.20-rc1.orig/drivers/ata/ahci.c
> linux-2.6.20-rc1/drivers/ata/ahci.c
> --- linux-2.6.20-rc1.orig/drivers/ata/ahci.c    2006-12-20 
> 10:25:00.000000000 +0800
> +++ linux-2.6.20-rc1/drivers/ata/ahci.c    2006-12-20 11:45:45.000000000 
> +0800
> @@ -418,7 +418,7 @@
> 
>     /* Generic, PCI class code for AHCI */
>     { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
> -      0x010601, 0xffffff, board_ahci },
> +      PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },
> 
>     { }    /* terminate list */
> };
> @@ -1586,11 +1586,11 @@
>         speed_s = "?";
> 
>     pci_read_config_word(pdev, 0x0a, &cc);
> -    if (cc == 0x0101)
> +    if (cc == PCI_CLASS_STORAGE_IDE)
>         scc_s = "IDE";
> -    else if (cc == 0x0106)
> +    else if (cc == PCI_CLASS_STORAGE_SATA)
>         scc_s = "SATA";
> -    else if (cc == 0x0104)
> +    else if (cc == PCI_CLASS_STORAGE_RAID)
>         scc_s = "RAID";
>     else
>         scc_s = "unknown";
> diff -Nur linux-2.6.20-rc1.orig/include/linux/pci_ids.h
> linux-2.6.20-rc1/include/linux/pci_ids.h
> --- linux-2.6.20-rc1.orig/include/linux/pci_ids.h    2006-12-20
> 10:24:51.000000000 +0800
> +++ linux-2.6.20-rc1/include/linux/pci_ids.h    2006-12-20 
> 11:45:07.000000000 +0800
> @@ -15,6 +15,8 @@
> #define PCI_CLASS_STORAGE_FLOPPY    0x0102
> #define PCI_CLASS_STORAGE_IPI        0x0103
> #define PCI_CLASS_STORAGE_RAID        0x0104
> +#define PCI_CLASS_STORAGE_SATA        0x0106
> +#define PCI_CLASS_STORAGE_SATA_AHCI    0x010601
> #define PCI_CLASS_STORAGE_SAS        0x0107
> #define PCI_CLASS_STORAGE_OTHER        0x0180
> 
> 
> BTW, the 2 patches above are just my suggestion, not formal patch. If
> either of them is acceptible, I will send out a formal patch. Thanks!

The above seems OK to me...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/