linux-kernel - [PATCH] romsignature/checksum cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45A1B10B.5080005@gmail.com>
Date:	Mon, 08 Jan 2007 03:48:43 +0100
From:	Rene Herman <rene.herman@...il.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andrew Morton <akpm@...l.org>
CC:	Zachary Amsden <zach@...are.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] romsignature/checksum cleanup

On 01/07/2007 07:07 PM, Jeremy Fitzhardinge wrote:

> Rene Herman wrote:

>> Doing the set_fs() and pagefault_{disable,enable} calls for every
>> single byte during the checksum seems rather silly.
> 
> Why?

Because it makes for dumb code. But oh well, given that it all compiles 
to basically nothing I guess I'll stop objecting.

Andrew: The attached removes the assumption that if the first page of an 
ISA ROM is mapped, it'll all be mapped. This'll also stop people reading 
this code from wondering if they're looking at a bug.

This replaces "romsignature-checksum-cleanup.patch" in current -mm.

Signed-off-by: Rene Herman <rene.herman@...il.com>
Not-strongly-objected-to-by: Jeremy Fitzhardinge <jeremy@...p.org>

Rene.

View attachment "probe_kernel_address.diff" of type "text/plain" (2059 bytes)