linux-kernel - Re: [PATCH] Broadcom 4400 resume small fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070108210112.GB28440@electric-eye.fr.zoreil.com>
Date:	Mon, 8 Jan 2007 22:01:12 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Dmitriy Monakhov <dmonakhov@...ru>
Cc:	linux-kernel@...r.kernel.org, zambrano@...adcom.com
Subject: Re: [PATCH] Broadcom 4400 resume small fix

Dmitriy Monakhov <dmonakhov@...ru> :
> Return value  of 'pci_enable_device' was ignored in b44_resume().
> We can't ingore it because it can fail.

- Please Cc: netdev@...r.kernel.org, jeff@...zik.org and the maintainer
  of the driver (Gary Zambrano <zambrano@...adcom.com> as per MAINTAINERS
  file and the log of the driveri).
- the dev_err() message fits completely on a 80 columns line.
- request-irq is not checked a few lines below either.

It would be nice to avoid the free_irq/pci_disable_device dance altogether.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/