linux-kernel - RE: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 8 Jan 2007 14:56:21 -0800
From:	"Lu, Yinghai" <yinghai.lu@....com>
To:	ebiederm@...ssion.com, "Andrew Morton" <akpm@...l.org>
cc:	"Linus Torvalds" <torvalds@...l.org>,
	"Tobias Diedrich" <ranma+kernel@...edrich.de>,
	"Adrian Bunk" <bunk@...sta.de>, "Andi Kleen" <ak@...e.de>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq
 if it is already there.

-----Original Message-----
From: ebiederm@...ssion.com [mailto:ebiederm@...ssion.com] 
Sent: Monday, January 08, 2007 2:50 PM
To: Andrew Morton
Cc: Linus Torvalds; Tobias Diedrich; Adrian Bunk; Andi Kleen; Linux
Kernel Mailing List; Lu, Yinghai
Subject: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq if
it is already there.

>Yep.  My oversight.  Here is the trivial patch to fix it.  I don't
>see how we could hit this case but if we are going to allow for it
>we should handle it correctly.

Yes, in your check_timer calling sequence, at that point irq can not be
0.
( remove_irq_to_pin already remove that entry).

Or in check_timer_pin

+	if ((irq != -1) && (irq != 0)) {

==>

+	if (irq != -1) {

YH



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/