linux-kernel - [PATCH 4/4] Make noirqdebug_setup function non init to fix modpost warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 8 Jan 2007 13:41:22 +0530
From:	Vivek Goyal <vgoyal@...ibm.com>
To:	linux kernel mailing list <linux-kernel@...r.kernel.org>
Cc:	Fastboot mailing list <fastboot@...ts.osdl.org>,
	Morton Andrew Morton <akpm@...l.org>, Andi Kleen <ak@....de>,
	Greg KH <gregkh@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: [PATCH 4/4] Make noirqdebug_setup function non init to fix modpost warning




o noirqdebug_setup() is __init but it is being called by
  quirk_intel_irqbalance() which if of type __devinit. If CONFIG_HOTPLUG=y,
  quirk_intel_irqbalance() is put into text section and it is wrong to
  call a function in __init section.

o MODPOST flags this on i386 if CONFIG_RELOCATABLE=y

WARNING: vmlinux - Section mismatch: reference to .init.text:noirqdebug_setup from .text between 'quirk_intel_irqbalance' (at offset 0xc010969e) and 'i8237A_suspend'

o Make noirqdebug_setup() non-init. 

Signed-off-by: Vivek Goyal <vgoyal@...ibm.com>
---

 kernel/irq/spurious.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/irq/spurious.c~make-noirqdebug_setup-function-non-init kernel/irq/spurious.c
--- linux-2.6.20-rc2-mm1-reloc/kernel/irq/spurious.c~make-noirqdebug_setup-function-non-init	2007-01-08 09:49:47.000000000 +0530
+++ linux-2.6.20-rc2-mm1-reloc-root/kernel/irq/spurious.c	2007-01-08 09:50:12.000000000 +0530
@@ -176,7 +176,7 @@ void note_interrupt(unsigned int irq, st
 
 int noirqdebug __read_mostly;
 
-int __init noirqdebug_setup(char *str)
+int noirqdebug_setup(char *str)
 {
 	noirqdebug = 1;
 	printk(KERN_INFO "IRQ lockup detection disabled\n");
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/