linux-kernel - Re: JFS: possible recursive locking detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Jan 2007 13:56:14 +0000
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Srinivasa Ds <srinivasa@...ibm.com>
Cc:	Tomasz Kvarsin <kvarsin@...il.com>, linux-kernel@...r.kernel.org,
	jfs-discussion@...ts.sourceforge.net,
	Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: JFS: possible recursive locking detected

On Tue, 2007-01-09 at 15:02 +0530, Srinivasa Ds wrote:
> Tomasz Kvarsin wrote:
> > This I got during boot with 2.6.20-rc4:
> > =============================================
> > [ INFO: possible recursive locking detected ]

... 

> So below patch should fix this problem,please test this. Let me know 
> your comments on this.

I'm sure there are several other places in the jfs code that need the
same treatment.  I've put this off too long already.  I'll get a
comprehensive lock annotation patch out today, starting with this one.

> 
> Signed-off-by: Srinivasa DS <srinivasa@...ibm.com>

Thanks,
Shaggy

> 
> 
> plain text document attachment (jfs.fix)
>  namei.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.20-rc4/fs/jfs/namei.c
> ===================================================================
> --- linux-2.6.20-rc4.orig/fs/jfs/namei.c
> +++ linux-2.6.20-rc4/fs/jfs/namei.c
> @@ -104,8 +104,8 @@ static int jfs_create(struct inode *dip,
>  
>  	tid = txBegin(dip->i_sb, 0);
>  
> -	mutex_lock(&JFS_IP(dip)->commit_mutex);
> -	mutex_lock(&JFS_IP(ip)->commit_mutex);
> +	mutex_lock_nested(&JFS_IP(dip)->commit_mutex, I_MUTEX_PARENT);
> +	mutex_lock_nested(&JFS_IP(ip)->commit_mutex, I_MUTEX_CHILD);
>  
>  	rc = jfs_init_acl(tid, ip, dip);
>  	if (rc)
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/