linux-kernel - Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45A3C4C5.5080405@xandros.com>
Date:	Tue, 9 Jan 2007 11:37:25 -0500
From:	Woody Suwalski <woodys@...dros.com>
To:	David Brownell <david-b@...bell.net>,
	Alessandro Zummo <alessandro.zummo@...ertech.it>
cc:	rtc-linux@...glegroups.com,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver

Russell King wrote:
> On Sat, Jan 06, 2007 at 01:17:25PM -0800, David Brownell wrote:
>   
>> On Saturday 06 January 2007 9:17 am, Woody Suwalski wrote:
>>     
>>>>> There are PPC, M68K, SPARC, and other boards that could also
>>>>> use this; ARMs tend to integrate some other RTC on-chip.  ...
>>>>>           
>>>> Let me put that differently.  That should be done as a separate
>>>> patch, adding (a) that platform_device, and maybe platform_data
>>>> if it's got additional alarm registers, and (b) Kconfig support
>>>> to let that work.  I'd call it a "patch #4 of 3".  ;)
>>>> ...
>>>>         
>>> I will try to play with the new code on Monday on ARM...
>>>       
>> Thanks.  Could you describe your ARM board?  None of mine have an
>> RTC using this register API.  Does it support system sleep states
>> (/sys/power/state) with a wakeup-capable (enable_irq_wake) RTC irq? 
>>     
>
> Woody will be using a Netwinder (he's part of the original development
> team.)  So no sleep states and therefore no wakeup.
>
> There's various other ARM-based systems using the PC RTC, but none of
> them have sleep or wakeup abilities afaik.
>
>   
I think that Russell is correct - the RTC is just part of a Winbond 
multifunction chip. It has no special wake-up or alarm hooks (as far as 
I remember).

As to the patch: applied to 2.6.20-rc4, both on PC and ARM, commented 
out "EXPERIMENTAL"...

To build your new patch for ARM I have modified the line "depends on 
RTC_CLASS && (X86_PC || ACPI || ARM)"...

On Netwinder ARM - can not build (see: rtc_build.log)

OK, changed the include/asm/rtc.h to look like i386 == include 
asm-generic/rtc.h
Still does not build - see rtc_build2.log

Could you please check what other defs are missing on ARM?

Thanks, Woody

BTW. Current RTC is broken same way on Shark ARM as it is on Netwinder ARM:

 >>>
<anderson@...sweng.com>
As for the RTC patch, it does work on the shark, and is needed.
<<<

So is there a reason to have RTC build blocked on all ARM?



View attachment "rtc_build.log" of type "text/x-log" (2828 bytes)

View attachment "rtc_build2.log" of type "text/x-log" (2179 bytes)