linux-kernel - Re: [PATCH] Clean up PPC code to use canonical alignment macros from kernel.h.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17826.46886.680834.928790@cargo.ozlabs.ibm.com>
Date:	Tue, 9 Jan 2007 08:27:02 +1100
From:	Paul Mackerras <paulus@...ba.org>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Clean up PPC code to use canonical alignment macros from
 kernel.h.

Robert P. J. Day writes:

>   Clean up some PowerPC source files to use the canonical alignment
> macros from kernel.h, and add an ALIGN_DOWN() macro to kernel.h for
> symmetry.

[snip]

>   and, no, i didn't test-compile this as i don't have a PPC
> cross-compiler at the moment.  sorry.

Yeah.  I would be surprised if it did build, since you are removing
definitions without adding any #includes to make sure we get the
global definition.

>  arch/powerpc/boot/addRamDisk.c               |    3 +--
>  arch/powerpc/boot/of.c                       |    2 +-
>  arch/powerpc/boot/page.h                     |    9 +--------
>  arch/powerpc/boot/simple_alloc.c             |    8 ++++----

NAK.  Stuff in arch/powerpc/boot intentionally *doesn't* depend on
Linux kernel headers, since it runs outside of the kernel, either on
the build machine (addRamDisk.c) or before the kernel.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/