linux-kernel - Re: [PATCH] ppc: cpm2_pic of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17827.8109.461427.191194@cargo.ozlabs.ibm.com>
Date:	Tue, 9 Jan 2007 15:53:01 +1100
From:	Paul Mackerras <paulus@...ba.org>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ppc: cpm2_pic of_node_get cleanup

Mariusz Kozlowski writes:

> 	This patch removes redundant argument check for of_node_get().
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>
> 
>  arch/powerpc/sysdev/cpm2_pic.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff -upr linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c
> --- linux-2.6.20-rc2-mm1-a/arch/powerpc/sysdev/cpm2_pic.c	2006-12-24 05:00:32.000000000 +0100
> +++ linux-2.6.20-rc2-mm1-b/arch/powerpc/sysdev/cpm2_pic.c	2007-01-02 02:04:25.000000000 +0100
> @@ -245,9 +245,7 @@ void cpm2_pic_init(struct device_node *n
>  	cpm2_intctl->ic_scprrl = 0x05309770;
>  
>  	/* create a legacy host */
> -	if (node)
> -		cpm2_pic_node = of_node_get(node);
> -
> +	cpm2_pic_node = of_node_get(node);

This is actually a semantic change, in that cpm2_pic_node always gets
assigned now, whereas previously it didn't if node == NULL.  Are you
sure that is OK?  If so, you need to add something to the patch
description explaining why it is OK.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/