linux-kernel - Re: mprotect abuse in slim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070110155845.GA373@sergelap.austin.ibm.com>
Date:	Wed, 10 Jan 2007 09:58:45 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	"Serge E. Hallyn" <serue@...ibm.com>,
	Christoph Hellwig <hch@...radead.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Mimi Zohar <zohar@...ibm.com>, akpm@...l.org,
	kjhall@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	safford@...f.watson.ibm.com
Subject: Re: mprotect abuse in slim

Quoting Pekka J Enberg (penberg@...helsinki.fi):
> On Tue, 9 Jan 2007, Serge E. Hallyn wrote:
> > Whatever happened with Pekka's revoke submissions?  Did you lose
> > interest after
> > http://www.kernel.org/pub/linux/kernel/people/penberg/patches/revoke/2.6.19-rc1/revoke-2.6.19-rc1,
> > or was it decided that the approach was unworkable?
> 
> Lack of time.

Ok great - then it's not dead  :)

> Also, I would love to hear comments on the way I am doing
> revoke on shared mappings. There are few open issues remaining, mainly,
> supporting munmap(2) for revoked mappings.

Hmm, I wanted to test your revoke-munmap.c to see what you get right now
with munmap, but a quick port of your patch to yesterdays -git on s390
gives me an oops on do_revoke.  I'll have to straighten that out when I
get a chance.

But since it looks like you just munmap the region now, shouldn't a
subsequent munmap by the app just return -EINVAL?  that seems appropriate
to me.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/