linux-kernel - Re: .version keeps being updated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0701101058200.3594@woody.osdl.org>
Date:	Wed, 10 Jan 2007 11:02:33 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Jean Delvare <khali@...ux-fr.org>
cc:	Roman Zippel <zippel@...ux-m68k.org>,
	Andrey Borzenkov <arvidjaar@...l.ru>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Andy Whitcroft <apw@...dowen.org>,
	Herbert Poetzl <herbert@...hfloor.at>,
	Olaf Hering <olaf@...fle.de>
Subject: Re: .version keeps being updated

On Wed, 10 Jan 2007, Jean Delvare wrote:
> 
> This fixes the problem I reported. Thanks Roman!
> 
> Linus, Andrew, if Roman's patch looks OK to you, can it please be
> applied before 2.6.20 is released?

I applied it, but looking closer at it, it becomes clear that Roman didn't 
understand the problem with that patch.

This part:

	const char __init linux_banner[] =

CANNOT work, because the stupid SuSE tool that look into the kernel binary 
searches for "Linux version " as the thing, and as such the "linux_banner" 
has to be the _first_ thing to trigger it for it to work.

Which is why "__init" is wrong. It causes the linker to either put it at 
the end of the thing (which would break the SuSE tool). Alternatively it 
causes section mismatch problems ("init" and "const" don't work that well 
together), in which case it might work, but only due to toolchain bugs.

Grr.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/