linux-kernel - Re: 2.6.20-rc4: known unfixed regressions (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45A58C33.4050909@yahoo.com.au>
Date:	Thu, 11 Jan 2007 12:00:35 +1100
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	"Vladimir V. Saveliev" <vs@...esys.com>
CC:	Linus Torvalds <torvalds@...l.org>, reiserfs-dev@...esys.com,
	Malte Schröder <MalteSch@....de>,
	Adrian Bunk <bunk@...sta.de>, Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.20-rc4: known unfixed regressions (v2)

Vladimir V. Saveliev wrote:
> Hello
> 
> On Tuesday 09 January 2007 21:30, Linus Torvalds wrote:
> 
>>On Tue, 9 Jan 2007, Malte Schröder wrote:
>>
>>>>So something interesting is definitely going on, but I don't know exactly
>>>>what it is. Why does reiserfs do the truncate as part of a close, if the
>>>>same inode is actually mapped somewhere else? 
> 
> 
> on file close reiserfs tries to "pack" content of last incomplete page of file into metadata blocks.
> It should not if that page is still mapped somewhere. 
> It does not actually truncate, it calls the same function which does truncate, but file size does not change.

That's racy, unfortunately :P

> 
> Please consider the below patch.

That seems like it would work. Probably papers over your truncate-inside-i_size as well.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/