linux-kernel - Re: [patch 2.6.20-rc3] rtc-sh correctly reports rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070111114034.GA6333@twibble.org>
Date:	Thu, 11 Jan 2007 22:40:35 +1100
From:	Jamie Lenehan <lenehan@...bble.org>
To:	David Brownell <david-b@...bell.net>,
	Alessandro Zummo <alessandro.zummo@...ertech.it>,
	Paul Mundt <lethal@...ux-sh.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	rtc-linux@...glegroups.com
Subject: Re: [patch 2.6.20-rc3] rtc-sh correctly reports rtc_wkalrm.enabled

On Fri, Jan 05, 2007 at 08:55:05PM -0800, David Brownell wrote:
[...]
> An audit of the RTC driver treatment of the "enabled" flag turned
> up a handful of clear bugs; most drivers handle it the same now

Yeah, I missed the existing of the enabled flag when I added alarm
support to the driver. Your patch is fine.

> This driver has another issue:  sh_rtc_set_alarm() ignores the
> "enabled" flag, rather than using it to tell whether the alarm
> should be enabled on exit from that routine.  One at a time.  :)

I'll can take care of this.

-- 
 Jamie Lenehan <lenehan@...bble.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/