linux-kernel - Re: [patch 00/12] Fix ppc64's writing to struct file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070114145411.1fd8c985@localhost.localdomain>
Date:	Sun, 14 Jan 2007 14:54:11 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [patch 00/12] Fix ppc64's writing to struct file_operations

>  	.read		= seq_read,
> +	.write		= lparcfg_write,
>  	.open		= lparcfg_open,
>  	.release	= single_release,
>  };
> @@ -581,10 +582,8 @@ int __init lparcfg_init(void)
>  
>  	/* Allow writing if we have FW_FEATURE_SPLPAR */
>  	if (firmware_has_feature(FW_FEATURE_SPLPAR) &&
> -			!firmware_has_feature(FW_FEATURE_ISERIES)) {
> -		lparcfg_fops.write = lparcfg_write;
> +			!firmware_has_feature(FW_FEATURE_ISERIES))
>  		mode |= S_IWUSR;
> -	}

This doesn't appea to do the same thing at all. You need to select
between two sets of const inode ops instead, otherwise you turn write on
arbitarily.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/