linux-kernel - Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Jan 2007 18:32:16 +0100
From:	Simon Budig <simon@...ig.de>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	Vojtech Pavlik <vojtech@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

Jiri Kosina (jikos@...os.cz) wrote:
> On Mon, 15 Jan 2007, Simon Budig wrote:
> > Yeah, it was easy to port over. Did the hid-debug stuff disappear
> > completely? What would I use instead?
> 
> No, it didn't disappear, it was just moved to include/linux/hid-debug.h. 
> Should I wait for an updated patch that uses hid-debug.h again?

Thanks, I missed that. Since these issues are unrelated I'll just submit
a trivial patch for the hid-debug.h stuff.

Is it possible that there is a regression in the hid-debug stuff? The
mapping does not seem to appear in the dmesg-output. I unfortunately
don't have an earlier kernel available right now to verify, but now the
output on plugging in the device looks like this:

[...]
usbcore: registered new interface driver hiddev
hid-debug: input GenericDesktop.X = 0
hid-debug: input GenericDesktop.Y = 0
hid-debug: input GenericDesktop.Z = 0
hid-debug: input GenericDesktop.Rx = 0
hid-debug: input GenericDesktop.Ry = 0
hid-debug: input GenericDesktop.Rz = 0
[...]

which looks bogus to me, IIRC earlier versions really printed the
mapping to linux input events at this point.

Anyway, the patch is correct anyway, will submit it soon.

Bye,
        Simon
-- 
              simon@...ig.de              http://simon.budig.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/