linux-kernel - Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070115185656.GB7161@suse.cz>
Date:	Mon, 15 Jan 2007 19:56:56 +0100
From:	Vojtech Pavlik <vojtech@...e.cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Jiri Kosina <jikos@...os.cz>, Simon Budig <simon@...ig.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

On Mon, Jan 15, 2007 at 07:38:10PM +0100, Marcel Holtmann wrote:
> Hi Vojtech,
> 
> > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h. 
> > 
> > Do you think that makes sense? It's code, not a header file.
> > 
> > > Should I wait for an updated patch that uses hid-debug.h again?
> 
> actually that code shouldn't be in a header file at all. It should be
> drivers/hid/hid-debug.c and the Makefile should compile it conditionally
> depending on a Kconfig option.
 
Agreed. It was a .h file just because of me being lazy.

-- 
Vojtech Pavlik
Director SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/