linux-kernel - Re: [PATCH] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1168829370.6068.2.camel@joejin-pc.cn.oracle.com>
Date:	Mon, 15 Jan 2007 10:49:30 +0800
From:	joe jin <joe.jin@...cle.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] bonding: Replace kmalloc() + memset() pairs with the
	appropriate kzalloc() calls

> Hi Joe,
> 
> On 1/12/07, joe jin <joe.jin@...cle.com> wrote:
> > @@ -788,7 +786,7 @@ static int rlb_initialize(struct bonding
> >
> >         spin_lock_init(&(bond_info->rx_hashtbl_lock));
> >
> > -       new_hashtbl = kmalloc(size, GFP_KERNEL);
> > +       new_hashtbl = kzalloc(size, GFP_KERNEL);
> >         if (!new_hashtbl) {
> >                 printk(KERN_ERR DRV_NAME
> >                        ": %s: Error: Failed to allocate RLB hash table\n",
> 
> You forgot to remove the memset here.

Here is not a memset :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/