linux-kernel - [PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1168965669760-git-send-email-ebiederm@xmission.com>
Date:	Tue, 16 Jan 2007 09:39:48 -0700
From:	"Eric W. Biederman" <ebiederm@...ssion.com>
To:	"<Andrew Morton" <akpm@...l.org>
Cc:	<linux-kernel@...r.kernel.org>, <containers@...ts.osdl.org>,
	<netdev@...r.kernel.org>, xfs-masters@....sgi.com, xfs@....sgi.com,
	linux-scsi@...r.kernel.org, James.Bottomley@...elEye.com,
	minyard@....org, openipmi-developer@...ts.sourceforge.net,
	<tony.luck@...el.com>, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com,
	linux-390@...marist.edu, paulus@...ba.org, linuxppc-dev@...abs.org,
	lethal@...ux-sh.org, linuxsh-shmedia-dev@...ts.sourceforge.net,
	<ak@...e.de>, vojtech@...e.cz, clemens@...isch.de,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-parport@...ts.infradead.org, andrea@...e.de,
	tim@...erelk.net, philb@....org, aharkes@...cmu.edu,
	coda@...cmu.edu, codalist@...EMANN.coda.cs.cmu.edu,
	aia21@...tab.net, linux-ntfs-dev@...ts.sourceforge.net,
	mark.fasheh@...cle.com, kurt.hackel@...cle.com,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: [PATCH 43/59] sysctl: Remove sys_sysctl support from drivers/char/rtc.c

From: Eric W. Biederman <ebiederm@...ssion.com> - unquoted

The real time clock driver was using the binary number reserved
for cdroms in the sysctl binary number interface, which is a no-no.
So since the sysctl binary interface is wrong remove it.

Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
---
 drivers/char/rtc.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 664f36c..df11289 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -282,7 +282,7 @@ irqreturn_t rtc_interrupt(int irq, void *dev_id)
  */
 static ctl_table rtc_table[] = {
 	{
-		.ctl_name	= 1,
+		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "max-user-freq",
 		.data		= &rtc_max_user_freq,
 		.maxlen		= sizeof(int),
@@ -294,9 +294,8 @@ static ctl_table rtc_table[] = {
 
 static ctl_table rtc_root[] = {
 	{
-		.ctl_name	= 1,
+		.ctl_name	= CTL_UNNUMBERED,
 		.procname	= "rtc",
-		.maxlen		= 0,
 		.mode		= 0555,
 		.child		= rtc_table,
 	},
@@ -307,7 +306,6 @@ static ctl_table dev_root[] = {
 	{
 		.ctl_name	= CTL_DEV,
 		.procname	= "dev",
-		.maxlen		= 0,
 		.mode		= 0555,
 		.child		= rtc_root,
 	},
-- 
1.4.4.1.g278f

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/