linux-kernel - Re: [PATCH] Fix compile warnings in r8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Jan 2007 19:33:21 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	linux-kernel@...r.kernel.org
Cc:	Bernhard Walle <bwalle@...e.de>
Subject: Re: [PATCH] Fix compile warnings in r8169

Bernhard Walle <bwalle@...e.de> :
> --- linux-2.6.20-rc4.orig/drivers/net/r8169.c	2007-01-07 06:45:51.000000000 +0100
> +++ linux-2.6.20-rc4/drivers/net/r8169.c	2007-01-17 11:39:13.792309228 +0100
[...]
> @@ -2227,7 +2227,7 @@ static int rtl8169_xmit_frags(struct rtl
>  {
>  	struct skb_shared_info *info = skb_shinfo(skb);
>  	unsigned int cur_frag, entry;
> -	struct TxDesc *txd;
> +	struct TxDesc *txd = NULL;
>  
>  	entry = tp->cur_tx;
>  	for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) {

The driver is right. This change does not alleviate the maintenance
of the driver nor does it add incentive to fix the compiler.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/