linux-kernel - Re: patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Jan 2007 11:21:15 -0800
From:	Greg KH <gregkh@...e.de>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	grundler@...isc-linux.org, akpm@...l.org, greg@...ah.com,
	kaneshige.kenji@...fujitsu.com, linux-kernel@...r.kernel.org,
	seto.hidetoshi@...fujitsu.com
Subject: Re: patch pci-rework-documentation-pci.txt.patch added to gregkh-2.6 tree

On Wed, Jan 17, 2007 at 10:09:08AM +0059, Jiri Slaby wrote:
> gregkh@...e.de wrote:
> [...]
> > +Tips on when/where to use the above attributes:
> > +	o The module_init()/module_exit() functions (and all
> > +	  initialization functions called _only_ from these)
> > +	  should be marked __init/__exit.
> > +
> > +	o Do not mark the struct pci_driver.
> > +
> > +	o The ID table array should be marked __devinitdata.
> 
> Is that correct? It panics somewehere IIRC?

If it's marked __initdata it can panic if we try to access the data when
adding a new PCI device after the system is up and running (pci hotplug
or dynamic pci ids support.)  That's why it needs to be either no
marking or __devinitdata (which resolves to nothing if CONFIG_HOTPLUG is
enabled.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/