linux-kernel - Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in arch/ppc/kernel/ppc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Jan 2007 14:16:54 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"<Andrew Morton" <akpm@...l.org>, linux-mips@...ux-mips.org,
	linux-parport@...ts.infradead.org, heiko.carstens@...ibm.com,
	ak@...e.de, linuxppc-dev@...abs.org, paulus@...ba.org,
	aharkes@...cmu.edu, schwidefsky@...ibm.com, tim@...erelk.net,
	rtc-linux@...glegroups.com, linux-scsi@...r.kernel.org,
	kurt.hackel@...cle.com, coda@...cmu.edu, vojtech@...e.cz,
	linuxsh-shmedia-dev@...ts.sourceforge.net,
	James.Bottomley@...elEye.com, clemens@...isch.de, xfs@....sgi.com,
	xfs-masters@....sgi.com, andrea@...e.de,
	openipmi-developer@...ts.sourceforge.net, linux-390@...marist.edu,
	codalist@...EMANN.coda.cs.cmu.edu, a.zummo@...ertech.it,
	tony.luck@...el.com, linux-ntfs-dev@...ts.sourceforge.net,
	netdev@...r.kernel.org, aia21@...tab.net,
	linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
	lethal@...ux-sh.org, containers@...ts.osdl.org,
	linux390@...ibm.com, philb@....org
Subject: Re: [PATCH 36/59] sysctl: C99 convert ctl_tables entries in
	arch/ppc/kernel/ppc_htab.c

On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@...ssion.com> - unquoted
> 
> And make the mode of the kernel directory 0555 no one is allowed
> to write to sysctl directories.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

> ---
>  arch/ppc/kernel/ppc_htab.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/ppc/kernel/ppc_htab.c b/arch/ppc/kernel/ppc_htab.c
> index bd129d3..77b20ff 100644
> --- a/arch/ppc/kernel/ppc_htab.c
> +++ b/arch/ppc/kernel/ppc_htab.c
> @@ -442,11 +442,16 @@ static ctl_table htab_ctl_table[]={
>  		.mode		= 0644,
>  		.proc_handler	= &proc_dol2crvec,
>  	},
> -	{ 0, },
> +	{}
>  };
>  static ctl_table htab_sysctl_root[] = {
> -	{ 1, "kernel", NULL, 0, 0755, htab_ctl_table, },
> - 	{ 0,},
> +	{
> +		.ctl_name	= CTL_KERN,
> +		.procname	= "kernel",
> +		.mode		= 0555,
> +		.child		= htab_ctl_table,
> +	},
> +	{}
>  };
>  
>  static int __init

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/