linux-kernel - Re: NFS causing oops when freeing namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1169074003.6523.15.camel@lade.trondhjem.org>
Date:	Wed, 17 Jan 2007 17:46:42 -0500
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Cedric Le Goater <clg@...ibm.com>, Oleg Nesterov <oleg@...sign.ru>,
	Daniel Hokka Zakrisson <daniel@...ac.com>,
	linux-kernel@...r.kernel.org, herbert@...hfloor.at, akpm@...l.org,
	Linux Containers <containers@...ts.osdl.org>
Subject: Re: NFS causing oops when freeing namespace

On Wed, 2007-01-17 at 15:30 -0700, Eric W. Biederman wrote:
> Cedric Le Goater <clg@...ibm.com> writes:
> >
> > your first analysis was correct : exit_task_namespaces() should be moved 
> > above exit_notify(tsk). It will require some extra fixes for nsproxy 
> > though.
> 
> I think the only issue is the child_reaper and currently we only have one of
> those.  When we really do the pid namespace we are going to have to revisit
> this.  My gut feel says that we won't be able to exit our pid namespace until
> the process is waited on.  So we may need to break up exit_task_namespace into
> individual components.

It makes little sense, afaics, to have an interruptible sleep in
something like lockd_down() if you have no pid space or signal handling.

That isn't the only place where the process has to wait in an NFS
unmount, BTW. Things like rpc client cleanup (waiting for all the RPC
tasks to complete) also tend to lead to interruptible sleeps.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/