linux-kernel - Re: [PATCH]: MTRR: fix 32-bit ioctls on x64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45AD9D59.6010006@zytor.com>
Date:	Tue, 16 Jan 2007 19:51:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mikael Pettersson <mikpe@...uu.se>
CC:	giuliano.procida@...glemail.com, rgooch@...f.csiro.au,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

Mikael Pettersson wrote:
> 
> These #ifdefs are too ugly.
> 
> Since you apparently just add aliases for the case labels,
> and do no actual code changes, why not
> 1. make the new cases unconditional, or 
> 2. invoke a translation function before the switch which
>    maps the MTRRCIOC32_ constants to what the kernel uses
> 

Adding a case can add substantially to the generated code, especially if 
it makes a compact set of case labels non-compact.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/