[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <E1H7dMw-0000hd-H6@be1.lrz>
Date: Thu, 18 Jan 2007 20:56:18 +0100
From: Bodo Eggert <7eggert@....de>
To: Alon Bar-Lev <alon.barlev@...il.com>,
Bernhard Walle <bwalle@...e.de>, linux-kernel@...r.kernel.org,
Alon Bar-Lev <alon.barlev@...il.com>
Subject: Re: [patch 03/26] Dynamic kernel command-line - arm
Alon Bar-Lev <alon.barlev@...il.com> wrote:
> On 1/18/07, Russell King <rmk+lkml@....linux.org.uk> wrote:
>> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
>> > 2. Set command_line as __initdata.
>> You can't.
>>
>> > -static char command_line[COMMAND_LINE_SIZE];
>> > +static char __initdata command_line[COMMAND_LINE_SIZE];
>>
>> Uninitialised data is placed in the BSS. Adding __initdata to BSS
>> data causes grief.
> There are many places in kernel that uses __initdata for uninitialized
> variables.
>
> For example:
> static int __initdata is_chipset_set[MAX_HWIFS];
>
> So all these current places are wrong?
> If I initialize the data will it be OK.
objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed
into .init.data here, not into .bss.
--
Top 100 things you don't want the sysadmin to say:
92. What software license?
Friß, Spammer: kq@....zi.7eggert.dyndns.org P-@...2Oo0.7eggert.dyndns.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists