linux-kernel - Re: [PATCH 1/2] Consolidate bust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1169120365.5621.4.camel@localhost>
Date:	Thu, 18 Jan 2007 12:39:25 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...nvz.org>
Cc:	akpm@...l.org, dev@...ru, linux-kernel@...r.kernel.org,
	devel@...nvz.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] Consolidate bust_spinlocks()

On Thu, 2007-01-18 at 14:16 +0300, Alexey Dobriyan wrote:
> From: Kirill Korotaev <dev@...ru>
> 
> Part of long forgotten patch
> http://groups.google.com/group/fa.linux.kernel/msg/e98e941ce1cf29f6?dmode=source
> Since then, m32r grabbed two copies.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...nvz.org>
> ---
> 
>  arch/i386/mm/fault.c       |   26 --------------------------
>  arch/ia64/kernel/traps.c   |   30 ------------------------------
>  arch/m32r/mm/fault-nommu.c |   26 --------------------------
>  arch/m32r/mm/fault.c       |   26 --------------------------
>  arch/s390/mm/fault.c       |   26 --------------------------
>  arch/x86_64/mm/fault.c     |   21 ---------------------
>  lib/Makefile               |    4 ++--
>  lib/bust_spinlocks.c       |    2 +-
>  8 files changed, 3 insertions(+), 158 deletions(-)

NACK for the s390 part. lib/bust_spinlocks.c does an unblank_screen if
CONFIG_VT is defined. That is not good enough for s390 because we do not
have CONFIG_VT nor unblank_screen but still require that console_unblank
is called.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/