linux-kernel - Re: [PATCH] Stop making "inline" imply forced inlining.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070119172542.GO9093@stusta.de>
Date:	Fri, 19 Jan 2007 18:25:42 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	rth@...ddle.net
Subject: Re: [PATCH] Stop making "inline" imply forced inlining.

On Fri, Jan 19, 2007 at 11:56:30AM -0500, Robert P. J. Day wrote:
> 
>   Remove the macros that define simple "inlining" to mean forced
> inlining, since you can (and *should*) get that effect with the
> CONFIG_FORCED_INLINING kernel config variable instead.

NAK.

I don't see any place in the kernel where we need a non-forced inline.

We have tons of inline's in C files that should simply be removed - 
let's do this instead.

> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> 
> ---
> 
>   this change was compile tested on x86 with "make allyesconfig",
> followed by turning off forced inlining.
> 
>   now the alpha folks can simplify their compiler.h file. :-)
> 
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 6e1c44a..5a90bd9 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -23,9 +23,6 @@
>      (typeof(ptr)) (__ptr + (off)); })
> 
> 
> -#define inline		inline		__attribute__((always_inline))
> -#define __inline__	__inline__	__attribute__((always_inline))
> -#define __inline	__inline	__attribute__((always_inline))
>  #define __deprecated			__attribute__((deprecated))
>  #define  noinline			__attribute__((noinline))
>  #define __attribute_pure__		__attribute__((pure))

Oh, and your patch would have been broken for gcc < 4.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/