linux-kernel - Re: [patch] hid: put usb_interface instead of usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0701191907580.31347@jikos.suse.cz>
Date:	Fri, 19 Jan 2007 19:14:16 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Anssi Hannula <anssi.hannula@...il.com>
Cc:	linux-usb-devel <linux-usb-devel@...ts.sourceforge.net>,
	linux-input@...ey.karlin.mff.cuni.cz,
	LKML <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [patch] hid: put usb_interface instead of usb_device into hid->dev

On Fri, 19 Jan 2007, Anssi Hannula wrote:

> The commit 4916b3a57fc94664677d439b911b8aaf86c7ec23 introduced a
> hid regression between 2.6.19 and 2.6.20-rc1. The device put in
> input_dev->cdev is now of type usb_device instead of usb_interface.

Yes, this is apparently a bug. Thanks a lot for the patch.

> Fix this by assigning the intf->dev into hid->dev, and fixing all the 
> users.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@...il.com>
> 
> ---
> 
> I recommend this fix to go to the stable tree before 2.6.20 is released.

Looks OK to me. I have queued it in HID tree - I am going to push this 
upstream in a few days.

-- 
Jiri Kosina

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/