linux-kernel - Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0701192324250.18606@yvahk01.tjqt.qr>
Date:	Fri, 19 Jan 2007 23:26:17 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Noah Watkins <nwatkins@...c.ku.edu>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode


>Subject: [PATCH] include linux/fs.h in linux/cdev.h for struct inode

NAK.

Better is this:

Add missing struct predeclarations, otherwise we may get

x.c:2: warning: ‘struct inode’ declared inside parameter list
x.c:2: warning: its scope is only this definition or declaration, which is
probably not what you want

Signed-off-by: Jan Engelhardt <jengelh@....de>

Index: linux-2.6.20-rc5/include/linux/cdev.h
===================================================================
--- linux-2.6.20-rc5.orig/include/linux/cdev.h
+++ linux-2.6.20-rc5/include/linux/cdev.h
@@ -6,6 +6,10 @@
 #include <linux/kdev_t.h>
 #include <linux/list.h>
 
+struct file_operations;
+struct inode;
+struct module;
+
 struct cdev {
 	struct kobject kobj;
 	struct module *owner;