linux-kernel - Re: [BUG] eth0 appers many times in /proc/interrupts after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070121212209.GB8958@slug>
Date:	Sun, 21 Jan 2007 21:22:09 +0000
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	Andrei Popa <andrei.popa@...eo.ro>
Cc:	linux-kernel@...r.kernel.org, nigel@...pend2.net
Subject: Re: [BUG] eth0 appers many times in /proc/interrupts after resume

On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote:
> It's the 10th resume and in /proc/interrupts eth0 appers 10 times.
> 
Hi,

The e100_resume() function should be calling netif_device_detach and
free_irq. Could you try the following (compile tested) patch?

Regards,
Frederik

Signed-off-by: Frederik Deweerdt <frederik.deweerdt@...il.com>

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 2fe0445..0c376e4 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -2671,6 +2671,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
 	del_timer_sync(&nic->watchdog);
 	netif_carrier_off(nic->netdev);
 
+	netif_device_detach(netdev);
 	pci_save_state(pdev);
 
 	if ((nic->flags & wol_magic) | e100_asf(nic)) {
@@ -2682,6 +2683,7 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
 	}
 
 	pci_disable_device(pdev);
+	free_irq(pdev->irq, netdev);
 	pci_set_power_state(pdev, PCI_D3hot);
 
 	return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/