linux-kernel - Re: [PATCH 2.6.20-rc3] CIFS: Remove 2 unneeded kzalloc casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Jan 2007 16:56:53 -0600
From:	Steven French <sfrench@...ibm.com>
To:	"Ahmed S. Darwish" <darwish.07@...il.com>
Cc:	linux-kernel@...r.kernel.org, sfrench@...ba.org
Subject: Re: [PATCH 2.6.20-rc3] CIFS: Remove 2 unneeded kzalloc casts

thx - I have added these to the cifs git tree.


Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com

"Ahmed S. Darwish" <darwish.07@...il.com> wrote on 01/06/2007 07:17:44 AM:

> Hi, 
> A patch to remove two unnecessary kzalloc casts found
> 
> Signed-off-by: Ahmed Darwish <darwish.07@...il.com>
> 
> diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
> index aedf683..90f95ed 100644
> --- a/fs/cifs/misc.c
> +++ b/fs/cifs/misc.c
> @@ -71,9 +71,7 @@ sesInfoAlloc(void)
>  {
>     struct cifsSesInfo *ret_buf;
> 
> -   ret_buf =
> -       (struct cifsSesInfo *) kzalloc(sizeof (struct cifsSesInfo),
> -                  GFP_KERNEL);
> +   ret_buf = kzalloc(sizeof (struct cifsSesInfo), GFP_KERNEL);
>     if (ret_buf) {
>        write_lock(&GlobalSMBSeslock);
>        atomic_inc(&sesInfoAllocCount);
> @@ -109,9 +107,8 @@ struct cifsTconInfo *
>  tconInfoAlloc(void)
>  {
>     struct cifsTconInfo *ret_buf;
> -   ret_buf =
> -       (struct cifsTconInfo *) kzalloc(sizeof (struct cifsTconInfo),
> -                   GFP_KERNEL);
> +   ret_buf = kzalloc(sizeof (struct cifsTconInfo),
> +           GFP_KERNEL);
>     if (ret_buf) {
>        write_lock(&GlobalSMBSeslock);
>        atomic_inc(&tconInfoAllocCount);
> 
> -- 
> Ahmed S. Darwish
> http://darwish-07.blogspot.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/