linux-kernel - Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070122151841.6d0473e4@localhost.localdomain>
Date:	Mon, 22 Jan 2007 15:18:41 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, James.Bottomley@...elEye.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM

On Sun, 21 Jan 2007 20:13:00 +0100
Adrian Bunk <bunk@...sta.de> wrote:

> Using assembler code for performance in drivers might have been a good 
> idea 15 years ago when this code was written, but with today's compilers 
> that's unlikely to be an advantage.
> 
> Besides this, it also hurts the readability.
> 
> Simply use the C code that was already there as an alternative.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
					"stosb\n\t"

NAK

The C codepaths are essentially untested on this driver.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/